@Enkidu93 reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ddaspit and @pmachapman).

src/SIL.Machine/Corpora/ScriptureRefUsfmParserHandlerBase.cs line 89 at r1 (raw file):

            }
            else if (
                VerseRef.AreOverlappingVersesRanges(verse1: verseRef.Verse, verse2: _curVerseRef.Verse)

Could you explain why you need to check both of these?

@pmachapman made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ddaspit and @Enkidu93).

src/SIL.Machine/Corpora/ScriptureRefUsfmParserHandlerBase.cs line 89 at r1 (raw file):

They may vary, as libpalaso uses a basic verse parsing method in VerseRef.AreOverlappingVersesRanges. Checking both ensures that both our parsed verse number and what VerseRef.AreOverlappingVersesRanges parses are the same.

@Enkidu93 made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ddaspit and @pmachapman).

src/SIL.Machine/Corpora/ScriptureRefUsfmParserHandlerBase.cs line 89 at r1 (raw file):

I see - that makes sense. Thank you! One of these days, we're just going to have to create a libpalaso PR to remedy all these VerseRef parsing oddities 😅.

@ddaspit reviewed 3 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @pmachapman).